Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

This is my confusion, we already have commits to bundle changes, why not simply allow commits to be reviewed independently within a pr?


Ok, then how do you approve/take the first 2 commits and not the last one? Or how do you insert a commit in between 2 commits or address feedback on a given commit?

The person making the change is now going to have to run multiple confusing interactive rebases and git shenanigans, the rewrite the history of the PR branch on every feedback, then you have to re-review all the commits again because they are all different.

It’s possible of course to push all that complexity on the tooling. Have GitHub and git provide tooling for doing all that within the context of a single branch/PR. But why is that better? Multiple branches are easier to manage in git, and as long as they don’t conflict on the merge. Obviously if a feedback on PR#1 causes a conflict in PR#2 which causes a conflict in PR#3 it’s still tedious, but it’s a lot more doable than managing interactive rebases on every feedback comment.


Jujutsu makes all this easy


Jujutsu makes the author-side of it all fairly nice, indeed. But the reviewer-side has been so horribly abandoned by github that it has been frustrating me for a long while now.


A JujutsuHub.com business opportunity presents itself. How many tokens do you have?


Already working on that!


Doesn't this have the same issue? If you need database changes that also need query changes or api changes, then you need to modify multiple commits.


This is similar to how things like Gerrit do code review, and it's pretty nice




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: